# Allow users to override command-line options
There's also a third option of implementing this properly, which would take more code than those 7 lines.Īlosarjos commented on 16:41 please apply also this patch to improve handling of comments and whitespace: diff -git a/brave-bin.sh b/brave-bin.sh Up to you Either revert my patch and accept the shell expansion, or apply my second patch and accept the limitations in format (each option on a new line and no quotes). There are many special characters in bash Īllowing the shell to expand them in this case is a bad idea IMO.
\S/p (with -n) - print only lines that contain at least one non-whitespace character (equivalent to grep '\S')Īre there chrome flags that accept * or white spaces to begin with or are we fixing imaginary issues? s/\s*$//g - remove whitespace at the end of each line s/^\s*//g - remove whitespace at the beginning of each line s/\s*#.*//g - remove comments and whitespace before them My regex skills are not at the point where I can understand that last sed, to be honest. Here, it's implemented in 7 lines of code, so there will be limitations. In chromium/chrome, this feature is a part of the browser. I don't like the fact that we are breaking previously running configs for others. ( libnotify-gtk2, libnotify-id, libnotify-git) (optional) – Native notification support (optional) – Enable GNOME keyring support ( cups-noudev, cups-nosystemd, cups-git) (optional) – Printer support ( neuropol-ttf, ttf-noto-fonts-ib, ttf-win7-fonts, ttf-ms-win8, ttf-ms-win8-arabic, ttf-ms-win8-hebrew, ttf-ms-win8-sea, ttf-ms-win8-indic, ttf-ms-win8-japanese, ttf-ms-win8-korean, ttf-ms-win8-zh_cn, ttf-ms-win8-zh_tw, ttf-ms-win8-thai, ttf-ms-win8-other, ttf-noto-fonts-simple, ttf-kids, ttf-gabriola, ttf-liberation-sans-narrow, ttf-cavafy-script, ttf-ms-fonts, ttf-dejavu-ib, ttf-zelda, ttf-oxygen, ttf-oxygen-gf, ttf-share-gf, ttf-gost, otf-inconsolata-dz, ttf-d2coding, ttf-ibm-plex-mono-git, ttf-dejavu-emojiless, ttf-agave, ttf-caracteres, ttf-cuprum, ttf-autour-one, ttf-impallari-milonga, ttf-impallari-miltonian, ttf-clarity-city, ttf-paratype, ttf-segoewp, ttf-karla, ttf-ms-win10, ttf-ms-win10-japanese, ttf-ms-win10-korean, ttf-ms-win10-sea, ttf-ms-win10-thai, ttf-ms-win10-zh_cn, ttf-ms-win10-zh_tw, ttf-ms-win10-other, ttf-win10, ttf-droid-simple, nerd-fonts-dejavu-complete, ttf-ms-win11, ttf-ms-win11-japanese, ttf-ms-win11-korean, ttf-ms-win11-sea, ttf-ms-win11-thai, ttf-ms-win11-zh_cn, ttf-ms-win11-zh_tw, ttf-ms-win11-other, ttf-ms-win10-auto, ttf-ms-win11-auto, ttf-ms-win10-cdn, noto-fonts-variable-lite, ttf-bmono, ttf-plemoljp, noto-fonts-lite, gnu-free-fonts, noto-fonts, ttf-bitstream-vera, ttf-croscore, ttf-dejavu, ttf-droid, ttf-ibm-plex, ttf-liberation) ( gtk3-git, gtk3-typeahead, gtk3-patched-filechooser-icon-view, gtk3-no_deadkeys_underline, gtk3-classic, gtk3-classic-noatk-64, gtk3-ubuntu)
( alsa-lib-git, alsa-lib-minimal-git, alsa-lib-x205ta)